]> 1 RESOLVED P3 FIXED Documentation CVS All issues@ofbiz 20030820210924 website ajzeneski not determined DEFECT 2003-08-13 22:35:10 issues@ofbiz All Website missing ajzeneski 2003-08-13 22:35:10 Website is missing from CVS. ajzeneski 2003-08-19 12:09:17 Website starting to move ajzeneski 2003-08-19 12:11:57 Changed milestone ajzeneski 2003-08-20 21:09:24 Website has been imported into CVS ajzeneski 2003-08-19 12:09:17 issue_status Status NEW STARTED ajzeneski 2003-08-19 12:09:17 version Version unspecified CVS ajzeneski 2003-08-19 12:11:57 target_milestone Target Milestone milestone 1 not determined ajzeneski 2003-08-20 21:09:24 issue_status Status STARTED RESOLVED ajzeneski 2003-08-20 21:09:24 resolution Resolution FIXED 2 RESOLVED P3 FIXED Components CVS All jonesde 20030824004146 Product ajzeneski not determined DEFECT 2003-08-23 14:25:20 issues@ofbiz All Missing FTL ajzeneski 2003-08-23 14:25:20 Missing FTL file: Error: File not found: /feature/EditFeatureCategoryFeatures.ftl jonesde 2003-08-24 00:41:46 Converted JSP to FTL, made some small corrections. jonesde 2003-08-24 00:41:46 issue_status Status NEW RESOLVED jonesde 2003-08-24 00:41:46 resolution Resolution FIXED 3 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20030828103031 Product ajzeneski not determined DEFECT 2003-08-23 14:27:14 issues@ofbiz All Edit Promo Bug ajzeneski 2003-08-23 14:27:14 When editing a promo rule; the drop down for the current condition contains only the existing condition (many times). jonesde 2003-08-28 10:30:31 #list directive had a type. Fix in CVS. jonesde 2003-08-28 10:30:31 issue_status Status NEW RESOLVED jonesde 2003-08-28 10:30:31 resolution Resolution FIXED 4 VERIFIED P3 FIXED Components CVS All issues@ofbiz 20030828103057 Product ajzeneski not determined DEFECT 2003-08-23 14:30:52 issues@ofbiz All Price Rule Bug ajzeneski 2003-08-23 14:30:52 When editing a price rule; changing the is "sale price" flag sets properly, however always displays "no" as the selected choice. jonesde 2003-08-28 10:20:59 Fixed conditional on the no button, now appears correctly. jonesde 2003-08-28 10:30:57 Done jonesde 2003-08-28 10:20:59 issue_status Status NEW RESOLVED jonesde 2003-08-28 10:20:59 resolution Resolution FIXED jonesde 2003-08-28 10:30:57 issue_status Status RESOLVED VERIFIED 5 NEW P3 Components CVS All issues@ofbiz 20030823144138 Party ajzeneski not determined DEFECT 2003-08-23 14:41:38 issues@ofbiz All Relationship missing button ajzeneski 2003-08-23 14:41:38 View/Edit party relationships page first is still JSP and second is missing the links to communication event(s). 6 CLOSED P3 INVALID Components CVS All issues@ofbiz 20030918144334 Entity robdawson not determined DEFECT 2003-09-04 02:09:57 jonesde All Entity Engine ConnectionFactory and DBCPConnectionFactory issues with Oracle robdawson 2003-09-04 02:09:57 When using the Inline JDBC Functionality of the Entity Engine to access an Oracle database the Entity Engine gives SQL no suitable driver exceptions. The fix for this involves changing: loader.loadClass(driverClassName); to Class clazz = loader.loadClass(driverClassName); clazz.newInstance(); in both the ConnectionFactory and DBCPConnectionFactory classes. There will also need to be the appropriate exception handling. Please contact me if this requires any clarification. ajzeneski 2003-09-04 22:15:06 The message you are getting means that the JDBC drivers for Oracle cannot be found on the classpath. Contact the users mailing list if you need further help with this issue. ajzeneski 2003-09-04 22:17:28 Sorry; DBCP support is currently outdated and not used due to the fact that there is no transaction support. It is recommended you use the JOTM/XAPool connections. This issue will be addressed during a refactor of this class in the coming months. jonesde 2003-09-18 14:43:34 This issue has been resolved with code changes similar to those recommended. HOWEVER: There is one caveat with this: I would NOT recommend running using either of these blocks of code. Without a transaction aware connection pool performance will be severely affected or operations may be performed outside of transactions. So, I wouldn't use straight JDBC or DBCP right now. Hopefully in the future DBCP will support XADataSources, then it may be an option. Later, -David Jones ajzeneski 2003-09-04 22:15:06 issue_status Status NEW RESOLVED ajzeneski 2003-09-04 22:15:06 resolution Resolution INVALID jonesde 2003-09-18 14:43:34 issue_status Status RESOLVED CLOSED jonesde 2003-09-18 14:43:34 qa_contact QA Contact issues@ofbiz jonesde 7 NEW P4 Components CVS All issues@ofbiz 20040304194045 WebTools fzhu_genshare not determined DEFECT 2003-09-21 07:35:08 issues@ofbiz http://localhost:8080/webtools/control/view/ModelGroupWriter?savetofile=true All "Save Entity Group XML to File" error 8 jonesde 2003-11-04 01:04:02 fzhu_genshare 2003-09-21 07:35:08 If click "Save Entity Group XML to File" on the webtools, the new page opens and the following error message appears: org.apache.jasper.JasperException: Unable to compile class for JSP An error occurred at line: -1 in the jsp file: null Generated servlet error: [javac] Since fork is true, ignoring compiler setting. [javac] Compiling 1 source file [javac] Since fork is true, ignoring compiler setting. [javac] C:\DOCUME~1\ADMINI~1\LOCALS~1 \Temp\Jetty_0_0_0_0_8080__webtools\entity\ModelGroupWriter_jsp.java:72: cannot resolve symbol [javac] symbol : variable entityGroupResourceHandler [javac] location: class org.ofbiz.entity.model.ModelGroupReader [javac] ResourceHandler resourceHandler = modelGroupReader.entityGroupResourceHandler; [javac] ^ [javac] 1 error jonesde 2003-11-04 01:04:02 *** Issue 8 has been marked as a duplicate of this issue. *** jonesde 2004-03-04 19:40:45 lower priority jonesde 2004-03-04 19:40:45 priority Priority P3 P4 8 RESOLVED P3 DUPLICATE Components CVS All issues@ofbiz 20031104010402 WebTools fzhu_genshare not determined DEFECT 2003-09-21 07:40:53 issues@ofbiz http://localhost:8080/webtools/control/view/ModelGroupWriter All "Generate Entity Group XML" error 7 jonesde 2003-11-04 01:04:02 fzhu_genshare 2003-09-21 07:40:53 If clicked "Generate Entity Group XML" on webtools, an error message occurs: org.apache.jasper.JasperException: Unable to compile class for JSP An error occurred at line: -1 in the jsp file: null Generated servlet error: [javac] Since fork is true, ignoring compiler setting. [javac] Compiling 1 source file [javac] Since fork is true, ignoring compiler setting. [javac] C:\DOCUME~1\ADMINI~1\LOCALS~1 \Temp\Jetty_0_0_0_0_8080__webtools\entity\ModelGroupWriter_jsp.java:72: cannot resolve symbol [javac] symbol : variable entityGroupResourceHandler [javac] location: class org.ofbiz.entity.model.ModelGroupReader [javac] ResourceHandler resourceHandler = modelGroupReader.entityGroupResourceHandler; [javac] ^ [javac] 1 error It seems the class ResourceHandler is missing. The same error result in several links of webtools concerning entity engine xml export broken. jonesde 2003-11-04 01:04:02 This issue is a duplicate of #7, they may be different links but they hit the same request and code. *** This issue has been marked as a duplicate of 7 *** jonesde 2003-11-04 01:04:02 issue_status Status NEW RESOLVED jonesde 2003-11-04 01:04:02 resolution Resolution DUPLICATE 9 RESOLVED P3 WONTFIX Components CVS All issues@ofbiz 20040223211140 Entity byersa not determined DEFECT 2003-10-28 09:27:31 issues@ofbiz All GenericEntity.getBytes fails with HSQLDB byersa 2003-10-28 09:27:31 getBytes internally casts to ByteWrapper which causes a ClassCastException. Casting directly to byte[] seems to work. Don't know if it fails with other dbs. jonesde 2004-02-23 21:11:40 This does not appear to be something that can be fixed in OFBiz, it appears to be a bug in HSQLDB, and only in certain versions. Trying it with an earlier version it worked, but various other things didn't. We may just have to be patient until HSQLDB has another stable release. jonesde 2004-02-23 21:11:40 issue_status Status NEW RESOLVED jonesde 2004-02-23 21:11:40 resolution Resolution WONTFIX 10 RESOLVED P5 FIXED Components CVS All ajzeneski 20040630193003 Service byersa not determined ENHANCEMENT 2003-10-31 08:53:59 issues@ofbiz All missing or incorrect service parameter message byersa 2003-10-31 08:53:59 If possible, I think it would be very helpful to developers if the message that informs on invalid service parameter conditions would clearly indicate whether it is in the IN or OUT mode that the problem is occurring. ajzeneski 2004-03-08 12:17:42 changed to enhancement ajzeneski 2004-03-08 17:49:18 reassigned ajzeneski 2004-06-30 19:30:03 The ServiceValidationException has been updated to support missing and extra fields as well as knowing which "mode" (IN/OUT) the error occured in. ajzeneski 2004-03-08 12:17:42 issue_type Issue Type DEFECT ENHANCEMENT ajzeneski 2004-03-08 12:17:42 priority Priority P3 P5 ajzeneski 2004-03-08 17:49:17 assigned_to Assigned To issues@ofbiz ajzeneski ajzeneski 2004-06-30 19:30:03 issue_status Status NEW RESOLVED ajzeneski 2004-06-30 19:30:03 resolution Resolution FIXED 11 RESOLVED P2 INVALID Components CVS PC jonesde 20031104002629 Content cyf not determined DEFECT 2003-11-03 22:26:18 issues@ofbiz Windows 2000 "response.sendRedirect" in jsp could not take effect cyf 2003-11-03 22:26:18 I have write a test.jsp code(like): ..... hello world! <%response.sendRedirect("control/main");%> .... define : in controller.xml: <request-map uri="test" edit="true"> <response name="success" type="view" value="test"/> <response name="error" type="view" value="error"/> </request-map> ..... <view-map name="test" type="region"/> in region also configued when I test the page : it's appear "hello world!",but didn't redirect. When I use this code as jsp page in normal web app,redirect can take effect. I think this is a bug of in region process. jonesde 2003-11-04 00:26:29 If I understand your complaint correctly it is because the way you organized things the response output stream is committed before the sendRedirect is called. There is absolutely nothing that can be done about this. If you want to send a redirect you should do so in an event or a non-region view (and non-jpublish for that matter). Those composite view tools are meant for generating views and involve templates that may cause the response to be committed before you wrapped view is even called. BTW, this may be more appropriate as a question on the users list, not as a defect bug report. Later, -David Jones jonesde 2003-11-04 00:26:29 issue_status Status NEW RESOLVED jonesde 2003-11-04 00:26:29 resolution Resolution INVALID 12 NEW P3 Components CVS All issues@ofbiz 20040223213513 Entity quake_wang not determined DEFECT 2003-11-04 01:39:16 issues@ofbiz All entity cache is not synchronized with DB quake_wang 2003-11-04 01:39:16 Quake, It might make sense to have an issue created on the ofbiz.dev.java.net site that covers this problem, since it may take some time to resolve. Could you create one there? It could just include text from messages send back and forth in this email thread. Thanks, -David On Nov 3, 2003, at 6:57 PM, Quake_Wang wrote: > The immutable flag can solve some cache synchronize issues, it will > help for debugging. But, please consider this scenario: > > Service A: > OK, now base on policy: "NEVER read from the cache if you are planning > on updating", we directly read from DB, > order = findByPK ("Order", 10000); > order.set("status", "DEF"); > order.store(); > > > Service B: > order = findByPKCache("Order", 10000); > just query, do not change any fields, entity engine will put the order > 10000 with "DEF" status in cache, after some other operations (not on > the order generic value) throw exception, rolled back service A and B, > then PKCache is not synchronized with DB too, the immutable flag can > not help any...... > > You wrote a service using cache for better performance, and someone > may assembly your service in same transaction (group service, ECA > service), the synchronizing may broken, it's really hard to find such > problem. > > Any ideas? > > Quake > > -----Original Message----- > From: David Jones [mailto:jonesde@ofbiz.org] > Sent: Monday, November 03, 2003 11:05 PM > To: dev@ofbiz.dev.java.net > Subject: Re: [OFBiz] Dev - Important - [Bug] PKCache is not > synchronized > with DB > > > > Because of the possibility that this is happening and causing > previously unexplained problems, I decided to go ahead and implement > the immutable feature on the GenericEntity. This is now in CVS, but may > cause problems with current code (and will most likely in many cases). > Do disable this just comment out the line near the beginning of the set > method in GenericEntity.java. It is around line 248 in the current > revision of the file. > > I fixed a few places that had this problem, including createCustomer in > ecommerce and the userLogin service. Creating a new customer and going > through the checkout process works fine now, but variations on the way > I did it may break. > > If we have too many problems with this, I'm okay with disabling it > temporarily, but it would be nice to go this direction in the future. > It will help resolve the possibility that strange things happen because > things are being changed in the cache when they shouldn't be and the > cache is out of sync with the database, ie is dirty. > > Feel free to report bugs along these lines, or better yet send > patches... > > Later, > -David > > > On Nov 3, 2003, at 5:24 AM, David Jones wrote: > >> >> Quake, >> >> Yes, I know this is a problem, although I had forgotten about it since >> it hasn't come up for a long time. >> >> Our official answer on this, related to the use of the cache in >> general is: NEVER read from the cache if you are planning on updating >> something. It's tempting to change the GenericValue object to have an >> unchangeable flag that is set for all versions that go into the >> cache.... >> >> I agree with you, there doesn't seem to be an easy way to >> automatically clear the cache on a rollback. In most cases the >> rollback doesn't even go through the Entity Engine, it is done in >> external code. So, the Entity Engine never gets a notification of the >> rollback, and if it did it would have to remember every operation that >> happened during that transaction so it could clear those dirty cache >> entries. >> >> Thus the policy: never use the cache to read when you are planning on >> writing to the database. And yeah, maybe I should throw some code in >> there to enforce this... Any thoughts from anyone on that? >> >> Later, >> -David >> >> >> >> On Nov 3, 2003, at 4:45 AM, Quake_Wang wrote: >> >>> Found a bug in the PKCache, below is the scenario >>> >>> Service A: >>> 1. find an order with the order No. 10000, dummy code: >>> order = findByPKCache("Order", 10000); >>> assume we get an order with the status "ABC"; >>> >>> 2. set the order status to "DEF" and store, dummy code: >>> order.set("status", "DEF"); >>> order.store(); >>> >>> Service B: >>> 1. find order 10000 again, dummy code: >>> order = findByPKCache("Order", 10000); >>> If the service A and B are in the same transaction (ex, group service >>> or ECA service), entity engine will get the order with "DEF" status >>> and put it in the PK cache. >>> >>> 2. some other operations, throw exception >>> Service A and B are rolled back, as the result, the PKCache is not >>> synchronized with DB: >>> DB: order 10000, status "ABC" >>> PKCache: order 10000, status "DEF" >>> >>> I spent some time to trace this bug, but can not find an easy way to >>> fix it, just simply change the findByPKCache to findByPK in service >>> B. >>> I'm sending out this email in hopes of helping who may encounter the >>> same problem and receiving a better fix method. >>> >>> Regards >>> Quake >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@ofbiz.dev.java.net >>> For additional commands, e-mail: dev-help@ofbiz.dev.java.net >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@ofbiz.dev.java.net >> For additional commands, e-mail: dev-help@ofbiz.dev.java.net > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ofbiz.dev.java.net > For additional commands, e-mail: dev-help@ofbiz.dev.java.net > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ofbiz.dev.java.net > For additional commands, e-mail: dev-help@ofbiz.dev.java.net --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ofbiz.dev.java.net For additional commands, e-mail: dev-help@ofbiz.dev.java.net jonesde 2004-02-23 21:35:13 Just a note on this. To fix it there need to be ThreadLocal caches that are maintained by a class that implements the Synchronization interface for transactions. The idea would be that cache reads look in the ThreadLocal cache first, then in the global cache, cache writes put everything in the ThreadLocal cache and when the transaction is committed all ThreadLocal cache entries go into the global cache. -David 13 RESOLVED P3 INVALID Components CVS All issues@ofbiz 20031112065558 Entity byersa not determined DEFECT 2003-11-12 06:15:27 issues@ofbiz All setNonPKFields byersa 2003-11-12 06:15:27 I had a situation in which I used setNonPKFields to populate an entity that had createdData and lastModifiedDate from parameters thinking that it would be a sort of parameter map. My intention was to then add the individual fields to a service input, but it turns out that instead of converting the date string to DateTime format, it kept them as strings and the service complained. I guess the GenericValue only converts datatypes during the persistence phase? If that is the case, it would be useful if it converted up loading. jonesde 2003-11-12 06:55:58 This is really not the responsibility of the GenericValue object (or really the GenericEntity object). This is difficult to handle as a defect report and should be sent to the dev mailing for discussion of the best way to go about what you are trying to do. The email message should perhaps include more detail about the overall goal you are trying to accomplish. Note that the GenericEntity, at the moment, does not enforce types going in, but may be changed to do that and throw an exception if the type is wrong. -David jonesde 2003-11-12 06:55:58 issue_status Status NEW RESOLVED jonesde 2003-11-12 06:55:58 resolution Resolution INVALID 14 NEW P3 Components CVS Macintosh issues@ofbiz 20040107162053 Order jonesde not determined DEFECT 2004-01-07 16:20:53 issues@ofbiz All Order Summary pages don't show free shipping promo jonesde 2004-01-07 16:20:53 Here is a description from Si Chen who reported the problem: One thing that I noticed that is anomalous, though, is that the order review pages still show an estimate for shipping charges, even though the customer should get free shipping. It seems that the checkout review pages are using org.ofbiz.order.shoppingcart.shipping.ShippingEvents.getShipEstimate, while on actual checkout it is using org.ofbiz.order.order.OrderReadHelper.getShippingTotal. The former is not taking into account shipping adjustments. 15 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040210064750 Order nowpulse not determined PATCH 2004-02-10 01:36:16 issues@ofbiz All Order Stats showing incorrect YTD info nowpulse 2004-02-10 01:36:16 The YTD info is incorrect since the Java month starts at 0 instead of 1. ofbiz/components/order/webapp/ordermgr/WEB-INF/actions/order/orderstats.bsh On Line 71 the 1 should be replaced with a 0 cal.set(Calendar.MONTH, 0); thank you, sterling jonesde 2004-02-10 06:47:50 Fixed as recommended. jonesde 2004-02-10 06:47:50 issue_status Status NEW RESOLVED jonesde 2004-02-10 06:47:50 resolution Resolution FIXED 16 NEW P4 Components CVS All jonesde 20040527233859 Product jonesde not determined FEATURE 2004-02-24 02:56:29 issues@ofbiz All Limit Categories Shown in Drop Downs jonesde 2004-02-24 02:56:29 Add "show in drop-down" option ProductCategory, filter by it in all combo style category drop downs, and change existing category drop-downs to be combo-boxes, include those on the EditProduct, EditProductCategories, EditCategory, EditCategoryProducts, EditPromoRules pages. jonesde 2004-05-27 23:38:59 Some progress has been made on this, but something still needs to be done with the form tool, etc to limit the drop downs. ajzeneski 2004-03-18 11:59:21 version Version Pre3.0.0 CVS jonesde 2004-05-27 23:38:59 priority Priority P1 P4 17 RESOLVED P1 FIXED Components CVS All jonesde 20040318120731 Product jonesde not determined FEATURE 2004-02-24 02:58:45 issues@ofbiz All Filter Promotion Products to exclude discontinued jonesde 2004-02-24 02:58:45 Add code to the ProductPromoWorker to (perhaps optionally) filter products included by the salesDiscontinuationDate, and of course make sure the category member from/thru dates are being honored. jonesde 2004-02-25 21:00:44 Now implemented. jonesde 2004-02-25 21:00:44 issue_status Status NEW RESOLVED jonesde 2004-02-25 21:00:44 resolution Resolution FIXED ajzeneski 2004-03-18 12:07:31 version Version Pre3.0.0 CVS 18 RESOLVED P1 FIXED Components CVS All jonesde 20040318120740 Product jonesde not determined DEFECT 2004-02-24 03:01:49 issues@ofbiz All Back ordered, or insufficient quantities not handled right jonesde 2004-02-24 03:01:49 It appears that when a product is back-ordered, or reserved in excess of the AvailableToPromise the calculations and setting of values are messed up. Here is a report on this from Bryce Ewing on Feb 5th, 2004: ================================================= I have found something that appears to be a bug (but I am not totally sure), I will explain this in two cases below: case 1: buy 1 item of product1 with no inventory - inventory item created with 0 on hand, and -1 available to promise - order item inventory res created with quantity of 1 and quantity not available of 1 case 2: buy 2 items of product2 with 1 item in inventory - inventory item updated with 1 on hand, and -1 available to promise - order item inventory res created with quantity of 2 and quantity not available of 0 For case 1 the system is doing exactly what I would expect, but in case 2 I would have expected that the order item inventory res record would have had a quantity not available of 1 rather than 0. Am I mistaken in this expectation, or is this infact a bug? ================================================= Here is a comment on some apparently related findings by Jacopo Cappellato: ================================================= I'm studying the simple method InventoryServices.reserveProductInventory that implements the inventory reservation of on order/order item, and I've got a question about this issue. What is the meaning of the quantityNotAvailable field in OrderItemInventoryRes entity? Where and how is it used (or intended to be used for)? I've noticed that this quantity is considered in the pick list reports... Probably the quantityNotAvailable field should contain the quantity reserved that caused inventory item's atp to be less than zero: if so, why in the reserveProductInventory method the quantityNotAvailable is set only in line 498 and not also after line 458? And in which way, once set, could this quantity return to zero? ================================================= jonesde 2004-02-24 18:35:45 After a patch from Bryce Ewing it appears to be fixed. jonesde 2004-02-24 18:35:45 issue_status Status NEW RESOLVED jonesde 2004-02-24 18:35:45 resolution Resolution FIXED ajzeneski 2004-03-18 12:07:40 version Version Pre3.0.0 CVS 19 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120748 Product jacopo not determined PATCH 2004-02-24 06:44:51 issues@ofbiz All Patch for bug in the Inventory Receive function jacopo 2004-02-24 06:44:51 In Facility manager, when you receive a purchase order delivered with more than one shipments and you select to receive only one shipment the proposed quantities are the quantities of the original purchase order and not the quantities of the shipment. In my patches I tried to change the minimum amount of code and the result is that the code is not well written... obviously feel free to change my code. PS: I submitted this patches to the dev list in january 2004. PPS: the two patches are in Unified Output Format Index: ofbiz/components/product/webapp/facility/inventory/receiveInventory.ftl =================================================================== RCS file: /cvs/ofbiz/components/product/webapp/facility/inventory/receiveInventory.f tl,v retrieving revision 1.5 diff -u -r1.5 receiveInventory.ftl --- ofbiz/components/product/webapp/facility/inventory/receiveInventory.ftl 17 Dec 2003 22:46:36 -0000 1.5 +++ ofbiz/components/product/webapp/facility/inventory/receiveInventory.ftl 14 Jan 2004 11:05:06 -0000 @@ -312,6 +312,9 @@ </tr> <#list purchaseOrderItems as orderItem> <#assign defaultQuantity = orderItem.quantity - receivedQuantities [orderItem.orderItemSeqId]?double> + <#if shipment?has_content> + <#assign defaultQuantity = shippedQuantities [orderItem.orderItemSeqId]?double - receivedQuantities [orderItem.orderItemSeqId]?double> + </#if> <#if 0 < defaultQuantity> <#assign orderItemType = orderItem.getRelatedOne("OrderItemType")> <input type="hidden" name="orderId_o_${rowCount}" value="${orderItem.orderId}"> Index: ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh =================================================================== RCS file: /cvs/ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh,v retrieving revision 1.4 diff -u -r1.4 receiveInventory.bsh --- ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh 25 Aug 2003 15:28:00 -0000 1.4 +++ ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh 14 Jan 2004 11:08:14 -0000 @@ -69,6 +69,7 @@ shipment = delegator.findByPrimaryKey("Shipment", UtilMisc.toMap ("shipmentId", shipmentId)); } +shippedQuantities = new HashMap(); purchaseOrderItems = null; if (purchaseOrder != null) { if (product != null) { @@ -80,14 +81,18 @@ exprs = new ArrayList(); while (issueIter.hasNext()) { issuance = issueIter.next(); - exprs.add(new EntityExpr("orderItemSeqId", EntityOperator.EQUALS, issuance.getString("orderItemSeqId"))); + exprs.add(new EntityExpr("orderItemSeqId", EntityOperator.EQUALS, issuance.getString("orderItemSeqId"))); + double issuanceQty = issuance.getDouble("quantity").doubleValue(); + if (shippedQuantities.containsKey(issuance.getString ("orderItemSeqId"))) { + issuanceQty += ((Double)shippedQuantities.get (issuance.getString("orderItemSeqId"))).doubleValue(); + } + shippedQuantities.put(issuance.getString("orderItemSeqId"), issuanceQty); } purchaseOrderItems = EntityUtil.filterByOr(orderItems, exprs); } else { purchaseOrderItems = purchaseOrder.getRelated("OrderItem"); } } - receivedQuantities = new HashMap(); if (purchaseOrderItems != null && purchaseOrderItems.size() > 0) { context.put("firstOrderItem", EntityUtil.getFirst(purchaseOrderItems)); @@ -100,7 +105,13 @@ if (receipts != null && receipts.size() > 0) { recIter = receipts.iterator(); while (recIter.hasNext()) { - rec = recIter.next(); + rec = recIter.next(); + if (shipment != null) { + if (rec.getString("shipmentId") == null || + !rec.getString("shipmentId").equals(shipment.getString ("shipmentId"))) { + continue; + } + } accepted = rec.getDouble("quantityAccepted"); rejected = rec.getDouble("quantityRejected"); if (accepted != null) @@ -140,6 +151,7 @@ context.put("product", product); context.put("shipments", shipments); context.put("shipment", shipment); +context.put("shippedQuantities", shippedQuantities); context.put("purchaseOrderItems", purchaseOrderItems); context.put("receivedQuantities", receivedQuantities); context.put("rejectReasons", rejectReasons); jacopo 2004-02-24 06:55:45 Created an attachment (id=1) Patch files in UOF for receiveInventory,bsh and receiveInventory.ftl jonesde 2004-03-01 06:35:22 The changes are in CVS. Thanks Jacopo! text/plain 1 2004-02-24 06:55:45 Patch files in UOF for receiveInventory,bsh and receiveInventory.ftl 1 receiveInventory.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/1/receiveInventory.patch jacopo 2004-02-24 06:55:45 attachments.ispatch Attachment is Patch Created an attachment (id=1) Patch files in UOF for receiveInventory,bsh and receiveInventory.ftl jonesde 2004-03-01 06:35:22 issue_status Status NEW RESOLVED jonesde 2004-03-01 06:35:22 resolution Resolution FIXED ajzeneski 2004-03-18 12:07:48 version Version Pre3.0.0 CVS 20 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120758 Party jacopo not determined PATCH 2004-02-24 07:36:49 issues@ofbiz All List All Visits link in the Party Profile page returns an error with 0 visits jacopo 2004-02-24 07:36:50 List All Visits link in the Party Profile page returns an error with 0 visits (see attached patch file) due to wrong bsh code. jacopo 2004-02-24 07:38:20 Created an attachment (id=2) Patch for bug in uof jonesde 2004-03-01 06:39:57 The changes are in CVS. Thanks Jacopo! text/plain 2 2004-02-24 07:38:20 Patch for bug in uof 1 showvisits.bsh.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/2/showvisits.bsh.patch jacopo 2004-02-24 07:38:20 attachments.ispatch Attachment is Patch Created an attachment (id=2) Patch for bug in uof jonesde 2004-03-01 06:39:57 issue_status Status NEW RESOLVED jonesde 2004-03-01 06:39:57 resolution Resolution FIXED ajzeneski 2004-03-18 12:07:58 version Version Pre3.0.0 CVS 21 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120807 Party jacopo not determined PATCH 2004-02-24 07:40:56 issues@ofbiz All findparty page returns JavaScript errors when clicking on the LookupParty link and when the lookup fields are hidden jacopo 2004-02-24 07:40:56 findparty page returns JavaScript errors when clicking on the LookupParty link and when the lookup fields are hidden. The attached patch should fix the problem. jacopo 2004-02-24 07:41:29 Created an attachment (id=3) Patch for bug in uof jonesde 2004-03-01 06:44:01 Your changes are in CVS. Thanks Jacopo! text/plain 3 2004-02-24 07:41:29 Patch for bug in uof 1 findparty.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/3/findparty.ftl.patch jacopo 2004-02-24 07:41:29 attachments.ispatch Attachment is Patch Created an attachment (id=3) Patch for bug in uof jonesde 2004-03-01 06:44:01 issue_status Status NEW RESOLVED jonesde 2004-03-01 06:44:01 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:07 version Version Pre3.0.0 CVS 22 NEW P3 Components CVS All ajzeneski 20040318115951 Order jacopo not determined DEFECT 2004-02-24 08:52:07 issues@ofbiz All Errors in order entry when "Payment Already Received" type is selected. jacopo 2004-02-24 08:52:08 In Order Entry: when you finalize an order and, in the "Order Entry Payment Settings" page, you select the "Payment Already Received" type, in the following page you get JavaScript errors when you click over the links (stating that the object "document.billsetupform" doesn't exist); and so you cannot submit the order. jonesde 2004-02-26 07:08:20 This has been an issue for a while now. It's good to have it in the tracking system since it may not get fixed right away. Andy is more aware of what is happening there than I am, so he may have more feedback on it. -David jonesde 2004-02-26 07:08:20 assigned_to Assigned To issues@ofbiz ajzeneski jonesde 2004-02-26 07:08:20 priority Priority P2 P3 ajzeneski 2004-03-18 11:59:51 version Version Pre3.0.0 CVS 23 NEW P4 Components CVS All ajzeneski 20040318120006 Product jacopo not determined DEFECT 2004-02-24 08:56:40 issues@ofbiz All Inventory receive ignores the inventory item id field. jacopo 2004-02-24 08:56:40 In Facility Manager -> Inventory receive: it always creates a new inventory item even if the "inventory item id" optional field is filled with an existing inventory item id. ajzeneski 2004-03-08 17:38:11 reassigned ajzeneski 2004-03-08 17:38:11 assigned_to Assigned To issues@ofbiz ajzeneski ajzeneski 2004-03-18 12:00:06 version Version Pre3.0.0 CVS 24 NEW P4 Components CVS All ajzeneski 20040318120024 Product jacopo not determined DEFECT 2004-02-24 09:01:59 issues@ofbiz All Receive return: it always creates serialized inventory items. jacopo 2004-02-24 09:01:59 In Facility Manager -->Receive return it always creates a serialized inventory item (even if 'non-serialized' is selected) and so the received quantities are lost (if more than one). ajzeneski 2004-03-08 17:38:55 reassigned ajzeneski 2004-03-08 17:38:55 assigned_to Assigned To issues@ofbiz ajzeneski ajzeneski 2004-03-18 12:00:24 version Version Pre3.0.0 CVS 25 RESOLVED P2 INVALID Components CVS All ajzeneski 20040318120814 Accounting jonesde not determined DEFECT 2004-02-25 14:58:53 issues@ofbiz All Permission Checks missing in various part of Accounting Manager jonesde 2004-02-25 14:58:53 Various pages in the Accounting Manager have no view permission checking, including the billing account, invoice, etc pages. jaz 2004-02-25 15:36:03 I'm not involved in this project. jonesde 2004-02-25 16:13:54 Fixed assigned to mistake. ajzeneski 2004-03-08 10:48:28 All components have a default VIEW permission based on the component configuration. Each page no longer needs to have the added code as long as require auth is set in the controller.xml file. The checkLogin event will make sure the user has the default permission for the specific component. Additional permissions are only necessary when not using the default permission. jaz 2004-02-25 15:36:03 assigned_to Assigned To jaz jonesde jonesde 2004-02-25 16:13:54 assigned_to Assigned To jonesde ajzeneski ajzeneski 2004-03-08 10:48:28 issue_status Status NEW RESOLVED ajzeneski 2004-03-08 10:48:28 resolution Resolution INVALID ajzeneski 2004-03-18 12:08:14 version Version Pre3.0.0 CVS 26 RESOLVED P3 FIXED Components CVS All ajzeneski 20040308115822 Order jonesde not determined DEFECT 2004-02-25 21:11:36 issues@ofbiz All Billing Account Errors jonesde 2004-02-25 21:11:36 This issue was reported by Si Chen, Olivier Heintz, and some others. The following is some text from an email fro Si Chen on Jan 26, 2004; the attached patch is also from this email. ======================================= Hello. After some work we have tracked down the problem with using billingAccount in the order manager and were able to fix it. The problem is stated in the order manager's billsettings.ftl, it was passing in "EXT_BILLACT|10000" for the checkoutPaymentId instead of separate checkoutPaymentId and billingAccountId. Olivier had suggested a good patch earlier which parses this form of checkoutPaymentId in the CheckOutEvents.java. We took a different approach and used code from ecommerce to pass both checkoutPaymentId and billingAccountId. We also fixed CheckOutEvents.java to get the billingAccountId from the request and associate it with the cart. Both are shown in the attached patch. One last problem: in ecommerce, in checkoutpayment.ftl, gift cards, credit cards, and billing accounts are all using "amount_<account_id>" as the name of the input fields. As a result, when the toggleBillingAccount javascript function tries to toggle the billing account selected for entering the amount to pay, it gets confused and cannot do this. As a result, when you use the multi-page rather than express checkout in ecommerce, it does not work properly. I'll be happy to elaborate on this if you need me to. ======================================= jonesde 2004-02-25 21:14:01 Created an attachment (id=4) Patch to fix BillingAccount issues ajzeneski 2004-03-08 11:58:22 Applied patch; fixed JS in ecommerce text/plain 4 2004-02-25 21:14:01 Patch to fix BillingAccount issues 1 BillingAccountError.patch 3 jonesde https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/4/BillingAccountError.patch jonesde 2004-02-25 21:14:01 attachments.ispatch Attachment is Patch Created an attachment (id=4) Patch to fix BillingAccount issues ajzeneski 2004-03-08 11:58:22 issue_status Status NEW RESOLVED ajzeneski 2004-03-08 11:58:22 resolution Resolution FIXED ajzeneski 2004-03-08 11:58:22 version Version Pre3.0.0 CVS 27 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120822 WorkEffort jacopo not determined PATCH 2004-02-26 03:20:00 issues@ofbiz All Patch for missing pagedef file for popup template that causes lookup error (due to i18n changes) jacopo 2004-02-26 03:20:00 The lookup link in New Event -> Parties page is broken. The popup template doesn't run the envsetup script that loads the localized labels. PATCH: add a file named "popup.xml" to the template folder containing the following lines: <?xml version="1.0" encoding="UTF-8"?> <page> <template-action name="/includes/envsetup.bsh"/> </page> jonesde 2004-03-01 07:16:55 I have added the popup.xml file to CVS. Thanks for sending it over Jacopo. jonesde 2004-03-01 07:16:55 issue_status Status NEW RESOLVED jonesde 2004-03-01 07:16:55 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:22 version Version Pre3.0.0 CVS 28 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040806161040 WorkEffort jacopo not determined PATCH 2004-02-26 03:32:11 issues@ofbiz All Added lookup link for parties in month view jacopo 2004-02-26 03:32:11 Added lookup link for parties in month view. All the stuff was already in place... I just added the link. However I think this is a very useful enhancement. jacopo 2004-02-26 03:32:44 Created an attachment (id=5) Patch in UOF jonesde 2004-03-03 08:10:20 Changed issue type as per email from Jacopo. jonesde 2004-08-06 16:10:40 Thanks Jacopo, this is now in CVS. text/plain 5 2004-02-26 03:32:44 Patch in UOF 1 month.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/5/month.ftl.patch jacopo 2004-02-26 03:32:44 attachments.ispatch Attachment is Patch Created an attachment (id=5) Patch in UOF jonesde 2004-03-03 08:10:20 issue_type Issue Type ENHANCEMENT PATCH ajzeneski 2004-03-18 12:00:44 version Version Pre3.0.0 CVS jonesde 2004-08-06 16:10:40 issue_status Status NEW RESOLVED jonesde 2004-08-06 16:10:40 resolution Resolution FIXED 29 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120831 WorkEffort jacopo not determined PATCH 2004-02-26 03:56:48 issues@ofbiz All When creating a new event from calendar, start and end date were not filled properly in the form jacopo 2004-02-26 03:56:48 When creating a new event from calendar, start and end date were not filled properly in the event form. The two patches (one for the event.ftl file and one for the event.bsh file) will solve this problem. jacopo 2004-02-26 03:59:24 Created an attachment (id=6) Patch for event.bsh in UOF jacopo 2004-02-26 03:59:58 Created an attachment (id=7) Patch for event.ftl file in UOF jonesde 2004-03-01 07:28:02 Your changes are in CVS, thanks Jacopo! text/plain 6 2004-02-26 03:59:24 Patch for event.bsh in UOF 1 event.bsh.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/6/event.bsh.patch text/plain 7 2004-02-26 03:59:58 Patch for event.ftl file in UOF 1 event.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/7/event.ftl.patch jacopo 2004-02-26 03:59:24 attachments.ispatch Attachment is Patch Created an attachment (id=6) Patch for event.bsh in UOF jacopo 2004-02-26 03:59:58 attachments.ispatch Attachment is Patch Created an attachment (id=7) Patch for event.ftl file in UOF jonesde 2004-03-01 07:28:02 issue_status Status NEW RESOLVED jonesde 2004-03-01 07:28:02 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:31 version Version Pre3.0.0 CVS 30 NEW P5 Components CVS All ajzeneski 20040308175050 Order jackhung not determined DEFECT 2004-02-26 04:17:49 issues@ofbiz All Fail to approval order jackhung 2004-02-26 04:17:49 19285437[ ControlServlet.java:133:DEBUG] [[[updateactivityassign] Servlet Starting, doing setup- total:0.0,since last(Begin):0.0]] 19285438[ ControlServlet.java:182:DEBUG] [[[updateactivityassign] Setup done, doing Event(s) and View(s)- total:0.0,since last([updateactivityas...):0.0]] 19285440[ RequestHandler.java:200:INFO ] [Processing Request]: updateactivityassign 19285744[ WfProcessMgrImpl.java:106:INFO ] [WfProcessMgr.init] : Create process manager (org.ofbiz.order[20030730144901] / ProcessOrder[20030730144901]) 19285890[ BshUtil.java:75 :ERROR] BSH Evaluation error. Sourced file: <Inline eval of: approvalCode.equals("0"); > : Attempt to resolve method: equals() on undefined variable or class name: approvalCode : at Line: 1 : in file: <Inline eval of: approvalCode.equals("0"); > : approvalCode .equals ( "0" ) at bsh.UtilEvalError.toEvalError(UtilEvalError.java:82) at bsh.UtilEvalError.toEvalError(UtilEvalError.java:87) at bsh.BSHMethodInvocation.eval(BSHMethodInvocation.java:79) at bsh.BSHPrimaryExpression.eval(BSHPrimaryExpression.java:69) at bsh.Interpreter.evalParsedScript(Interpreter.java:1104) at bsh.Interpreter.eval(Interpreter.java:590) at bsh.Interpreter.eval(Interpreter.java:616) at bsh.Interpreter.eval(Interpreter.java:606) at org.ofbiz.base.util.BshUtil.eval(BshUtil.java:64) at org.ofbiz.workflow.impl.WfExecutionObjectImpl.evalBshCondition(WfExecutionObjectImpl.java:718) at org.ofbiz.workflow.impl.WfProcessImpl.getTransFrom(WfProcessImpl.java:477) at org.ofbiz.workflow.impl.WfProcessImpl.queueNext(WfProcessImpl.java:298) at org.ofbiz.workflow.impl.WfProcessImpl.activityComplete(WfProcessImpl.java:286) at org.ofbiz.workflow.impl.WfActivityImpl.complete(WfActivityImpl.java:408) at org.ofbiz.workflow.impl.WfAssignmentImpl.complete(WfAssignmentImpl.java:175) at org.ofbiz.workflow.client.WorkflowClient.complete(WorkflowClient.java:266) at org.ofbiz.workflow.client.WorkflowServices.completeAssignment(WorkflowServices.java:418) ajzeneski 2004-03-08 12:08:46 I cannot duplicate this problem; please provide more information or we will have to close this has no longer an issue. ajzeneski 2004-03-08 17:50:50 reassigned ajzeneski 2004-03-08 12:08:46 issue_status Status NEW STARTED ajzeneski 2004-03-08 12:08:46 op_sys OS/Version Linux All ajzeneski 2004-03-08 12:08:46 rep_platform Platform PC All ajzeneski 2004-03-08 12:08:46 short_desc Summary Fail to approval order Fail to approval order ajzeneski 2004-03-08 17:50:50 assigned_to Assigned To issues@ofbiz ajzeneski ajzeneski 2004-03-08 17:50:50 issue_status Status STARTED NEW ajzeneski 2004-03-08 17:50:50 priority Priority P2 P5 31 NEW P3 Components CVS All issues@ofbiz 20040318120101 WorkEffort jacopo not determined DEFECT 2004-02-26 05:39:36 issues@ofbiz All Error message when you try to create new contact information under an event jacopo 2004-02-26 05:39:36 An error message is returned when you try to create new contact information under an event: Cannot locate service by name (createWorkEffortContactMech) This is the complete message: ERROR: Could not complete the Create an email address for WorkEffort process [problem invoking the [createWorkEffortContactMech] service with the map named [context] containing [{locale=en_US, infoString=foo@bar.com, userLogin= [GenericEntity:UserLogin][partyId,admin(java.lang.String)][disabledDateTime,null ()][passwordHint,null()][createdTxStamp,null()][successiveFailedLogins,null()] [enabled,Y(java.lang.String)][userLoginId,admin(java.lang.String)] [currentPassword,ofbiz(java.lang.String)][lastUpdatedTxStamp,null()] [lastUpdatedStamp,null()][createdStamp,null()], workEffortId=10030, contactMechTypeId=EMAIL_ADDRESS}]: Cannot locate service by name (createWorkEffortContactMech)] ajzeneski 2004-03-18 12:01:01 version Version Pre3.0.0 CVS 32 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040409054533 WorkEffort jacopo not determined DEFECT 2004-02-26 05:50:01 issues@ofbiz All Errors that prevent adding a new phase to a project. jacopo 2004-02-26 05:50:01 It's impossible to add a new phase to a project. Even if you fill all the fields of the new phase form when you press the 'create' button you get an error in the system log (however no error messages are shown in the html page). This is the complete error message: 1160388[ ServiceDispatcher.java:309:ERROR] Service Error [createPhase]: ERROR: Could not complete the Create Project Phase process [problem creating the newEnt ity value: while inserting: [GenericEntity:WorkEffortAssoc][createdTxStamp,2004- 02-26 14:44:26.096(java.sql.Timestamp)][workEffortIdTo,10034(java.lang.String)][ workEffortIdFrom,10031(java.lang.String)][workEffortAssocTypeId,WORK_EFF_BREAKDO WN(java.lang.String)][lastUpdatedTxStamp,2004-02-26 14:44:26.096(java.sql.Timest amp)][createdStamp,2004-02-26 14:44:26.106(java.sql.Timestamp)][lastUpdatedStamp ,2004-02-26 14:44:26.106(java.sql.Timestamp)] (SQL Exception while executing the following:INSERT INTO WORK_EFFORT_ASSOC (WORK_EFFORT_ID_FROM, WORK_EFFORT_ID_TO , WORK_EFFORT_ASSOC_TYPE_ID, SEQUENCE_NUM, FROM_DATE, THRU_DATE, LAST_UPDATED_ST AMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ([-5005] (at 124): Missing non-NULL value))] jacopo 2004-04-09 05:45:33 David Jones has fixed this problem in date 2004-04-08 (see the thread "createphase ERROR in OFBiz 3.0 and OFBiz CVS versions" in the dev-list). ajzeneski 2004-03-18 12:01:18 version Version Pre3.0.0 CVS jacopo 2004-04-09 05:45:33 issue_status Status NEW RESOLVED jacopo 2004-04-09 05:45:33 resolution Resolution FIXED 33 RESOLVED P4 FIXED Components CVS All issues@ofbiz 20050209023142 WorkEffort jacopo not determined DEFECT 2004-02-26 06:00:26 issues@ofbiz All When you create a new request and you don't fill correctly all the fields no error messages are shown jacopo 2004-02-26 06:00:26 When you create a new request and you don't fill correctly all the fields no error messages are shown. jacopo 2005-02-09 02:31:42 Fixed after the refactoring to screen widget. ajzeneski 2004-03-18 12:01:30 version Version Pre3.0.0 CVS jacopo 2005-02-09 02:31:42 issue_status Status NEW RESOLVED jacopo 2005-02-09 02:31:42 resolution Resolution FIXED 34 RESOLVED P5 FIXED Components CVS All issues@ofbiz 20040318120838 Order jacopo not determined PATCH 2004-02-26 06:11:14 issues@ofbiz All Little JavaScript in "find returns" when lookup fields are hidden jacopo 2004-02-26 06:11:14 Little JavaScript in "find returns" when lookup fields are hidden Patch for findReturns.ftl is attached. jacopo 2004-02-26 06:11:49 Created an attachment (id=8) Patch for findReturn.ftl in UOF jonesde 2004-03-01 11:18:49 Your changes are in CVS. Thanks for sending that over. text/plain 8 2004-02-26 06:11:49 Patch for findReturn.ftl in UOF 1 findReturn.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/8/findReturn.ftl.patch jacopo 2004-02-26 06:11:49 attachments.ispatch Attachment is Patch Created an attachment (id=8) Patch for findReturn.ftl in UOF jonesde 2004-03-01 11:18:49 issue_status Status NEW RESOLVED jonesde 2004-03-01 11:18:49 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:38 version Version Pre3.0.0 CVS 35 RESOLVED P1 FIXED Components CVS All ajzeneski 20040308103928 E-Commerce razorb not determined DEFECT 2004-02-26 06:18:48 issues@ofbiz http://localhost:8080/ecommerce/control/product/~category_id=100/~product_id=GZ-1006 All Single variant combo doesn't select properly razorb 2004-02-26 06:18:48 Using the drop down menu to select a variantion i.e. LGPL does not set the selection on the menu. Using the swatch/images does correctly set the menu selection and allows adding to the basket. I suspect a little JS error somewhere for single variant items. jonesde 2004-02-26 06:52:49 I just reproduced this against the latest code base, appears to still be an issue with single feature type virtual products. ajzeneski 2004-03-08 09:54:51 Updated since this is a CVS bug and updated status ajzeneski 2004-03-08 10:39:28 fixed JS bugs in productdetail jonesde 2004-02-26 06:52:48 assigned_to Assigned To issues@ofbiz ajzeneski jonesde 2004-02-26 06:52:48 priority Priority P3 P1 ajzeneski 2004-03-08 09:54:51 issue_status Status NEW STARTED ajzeneski 2004-03-08 09:54:51 version Version Pre3.0.0 CVS ajzeneski 2004-03-08 10:39:28 issue_status Status STARTED RESOLVED ajzeneski 2004-03-08 10:39:28 resolution Resolution FIXED 36 RESOLVED P2 FIXED Components CVS All issues@ofbiz 20040318120846 Product jacopo not determined PATCH 2004-02-26 23:17:51 issues@ofbiz All Facility Manager: in 'inventory receive' the type of order is not checked and it's possible to receive a sales order if you enter its id in the 'purchase order id' field jacopo 2004-02-26 23:17:51 Facility Manager: in 'inventory receive' the type of order is not checked and it's possible to receive a sales order if you enter its id in the 'purchase order id' field. This is the patch in UOF for the receiveInventory.bsh file (pay attention that some days ago I've submitted a patch for the same file against the same CVS release): Index: ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh =================================================================== RCS file: /cvs/ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh,v retrieving revision 1.4 diff -u -r1.4 receiveInventory.bsh --- ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh 25 Aug 2003 15:28:00 -0000 1.4 +++ ofbiz/components/product/webapp/facility/WEB- INF/actions/inventory/receiveInventory.bsh 27 Feb 2004 07:17:08 -0000 @@ -43,6 +43,9 @@ purchaseOrder = null; if (purchaseOrderId != null && purchaseOrderId.length() > 0) { purchaseOrder = delegator.findByPrimaryKey("OrderHeader", UtilMisc.toMap ("orderId", purchaseOrderId)); + if (purchaseOrder != null && !"PURCHASE_ORDER".equals (purchaseOrder.getString("orderTypeId"))) { + purchaseOrder = null; + } } product = null; jonesde 2004-02-28 11:58:13 The patch is in CVS. jonesde 2004-02-28 11:58:13 issue_status Status NEW RESOLVED jonesde 2004-02-28 11:58:13 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:46 version Version Pre3.0.0 CVS 37 RESOLVED P2 FIXED Components CVS All issues@ofbiz 20040318120856 Product jacopo not determined DEFECT 2004-02-27 02:05:25 issues@ofbiz All Facility Manager: error message when trying to confirm stock moves needed. jacopo 2004-02-27 02:05:25 In the Facility Manager, int the PickList -> Stock Moves page, if I try to confirm the "stock moves needed" proposed by the system I get the following error: Error calling event: org.ofbiz.content.webapp.event.EventHandlerException: No rows to process And the movements are not performed. jonesde 2004-03-01 17:22:23 This is caused by some code that was added to display warning messages that wiped out the rowCount variable. The warning message loop now uses a variable names messageCount. jonesde 2004-03-01 17:22:23 issue_status Status NEW RESOLVED jonesde 2004-03-01 17:22:23 resolution Resolution FIXED ajzeneski 2004-03-18 12:08:56 version Version Pre3.0.0 CVS 38 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120905 Product jacopo not determined PATCH 2004-02-27 02:23:36 issues@ofbiz All Facility Manager: in Edit shipment -> items tab, a wrong link to EditProduct page caused a controller error. jacopo 2004-02-27 02:23:36 Facility Manager: in Edit shipment -> items tab, a wrong link to EditProduct page caused a controller error. Patch for EditShipmentItems.ftl file is attached. jacopo 2004-02-27 02:24:16 Created an attachment (id=9) Patch for EditShipmentItems.ftl in UOF jonesde 2004-03-01 07:38:50 Your changes are in CVS. Thanks for the patch Jacopo. text/plain 9 2004-02-27 02:24:16 Patch for EditShipmentItems.ftl in UOF 1 EditShipmentItems.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/9/EditShipmentItems.ftl.patch jacopo 2004-02-27 02:24:16 attachments.ispatch Attachment is Patch Created an attachment (id=9) Patch for EditShipmentItems.ftl in UOF jonesde 2004-03-01 07:38:50 issue_status Status NEW RESOLVED jonesde 2004-03-01 07:38:50 resolution Resolution FIXED ajzeneski 2004-03-18 12:09:05 version Version Pre3.0.0 CVS 39 NEW P2 Components CVS All issues@ofbiz 20040318120141 Order jacopo not determined DEFECT 2004-02-27 04:05:34 issues@ofbiz All SapDB problem when displaying order task list assigned to user role jacopo 2004-02-27 04:05:34 SapDB problem when displaying order task list assigned to user role: if more than one order is assigned to user role, in "Order List" page the orders are shown 5 times! If only one order is assigned to the user role, the order is shown well (1 time). See picture attached. jacopo 2004-02-27 04:07:00 Created an attachment (id=10) Bug example showing two orders waiting approval duplicated 5 times. image/gif 10 2004-02-27 04:07:00 Bug example showing two orders waiting approval duplicated 5 times. order_list_bug.GIF 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/10/order_list_bug.GIF jacopo 2004-02-27 04:07:00 attachments.thedata Attachment Data Created an attachment (id=10) Bug example showing two orders waiting approval duplicated 5 times. ajzeneski 2004-03-18 12:01:41 version Version Pre3.0.0 CVS 40 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20050209023003 WorkEffort jacopo not determined DEFECT 2004-02-27 07:27:15 issues@ofbiz All Party lookup with empty fields returns only one person repeated many times (= number of persons). jacopo 2004-02-27 07:27:15 If, in Party lookup, you perform a lookup with empty fields (all records), returns only one person repeated many times (= number of persons). I suspect that the problem is in the "lookupParty" simple method in common component. jacopo 2005-02-09 02:30:03 Fixed changing the way the lookup is implemented (see Jira issue OFBIZ-114). ajzeneski 2004-03-18 12:01:50 version Version Pre3.0.0 CVS jacopo 2005-02-09 02:30:03 issue_status Status NEW RESOLVED jacopo 2005-02-09 02:30:03 resolution Resolution FIXED 41 RESOLVED P3 FIXED Components CVS All issues@ofbiz 20040318120912 Product jacopo not determined PATCH 2004-02-27 08:53:04 issues@ofbiz All Facility Manager: in Edit shipment -> items tab, a wrong link to EditProduct caused a controller error (same as issue #38) jacopo 2004-02-27 08:53:04 Facility Manager: in View shipment tab, a wrong link to EditProduct page caused a controller error (same as issue #38). Patch for ViewShipmentItemInfo.ftl file is attached. jacopo 2004-02-27 08:53:50 Created an attachment (id=11) Patch for file ViewShipmentItemInfo.ftl in UOF jonesde 2004-03-01 07:41:15 Your changes are now in CVS. Thanks for sending those over Jacopo. text/plain 11 2004-02-27 08:53:50 Patch for file ViewShipmentItemInfo.ftl in UOF 1 ViewShipmentItemInfo.ftl.patch 194 jacopo https://ofbiz.dev.java.net/nonav/issues/showattachment.cgi/11/ViewShipmentItemInfo.ftl.patch jacopo 2004-02-27 08:53:50 attachments.ispatch Attachment is Patch Created an attachment (id=11) Patch for file ViewShipmentItemInfo.ftl in UOF jonesde 2004-03-01 07:41:15 issue_status Status NEW RESOLVED jonesde 2004-03-01 07:41:15 resolution Resolution FIXED ajzeneski 2004-03-18 12:09:12 version Version Pre3.0.0 CVS 42 RESOLVED P4 WONTFIX Components CVS All ajzeneski 20040630193328 Product jacopo not determined DEFECT 2004-02-28 22:34:42 issues@ofbiz All In shipment, the following error message appears: "Applet Package Weight Reader notinited" jacopo 2004-02-28 22:34:42 In shipment, the following error message appears: "Applet Package Weight Reader notinited". I think the problem is caused by the fact that the class ShipmentScaleApplet is not built in the ant task. Was this done intentionally? (I think this applet tries to connect to a scale device