[PATCH] REXML::Element#delete_attribute not behaving correctly

[fbuilesv]

Detailed description

According to the REXML::Element#delete_attribute docs, it should be able to receive either a String or an Attribute and then proceed to delete it if it exists. This is currently failing when it receives an Attributes as the parameter:

e = REXML::Element.new("foo")

=> <foo/>

a = REXML::Attribute.new("bar", "bla")

=> bar='bla'

e.add_attribute(a)

=> bar='bla'

e.delete_attribute(a)

=> nil

e.attributes

=> {"bar"=>bar='bla'} # attribute was not removed

The attached patch fixes it by making sure it passes only the Attribute's name to Attributes#get_attributes.

[fbuilesv]

Patch for delete_attribute and a small doc fix.

[fbuilesv]

Also, the patch fixes a small error on the docs, the return value mentioned says it returns the deleted attribute but the examples and the behavior show that it returns the element with the attribute removed.