Ticket #128 (closed defect: fixed)

Opened 5 months ago

Last modified 4 months ago

Element.write fails

Reported by: michaelparker Owned by: rubys
Priority: normal Milestone: 3.1.8
Component: DOM Version:
Severity: major Keywords:
Cc: Ruby version: Other
Operating system: All

Description

Version Info

ruby 1.8.6 (2007-09-23 patchlevel 110) [i686-linux]
"3.1.7.1"
"i686-linux"

Error message

NameError: undefined local variable or method `output' for #<REXML::Element:0xb7c444f8>
        from /opt/aspera/lib/ruby/lib/ruby/1.8/rexml/element.rb:684:in `write'

Patch

File: http://www.germane-software.com/projects/rexml/browser/trunk/src/rexml/element.rb
Rev: r1281
Line: 674

---    def write(writer=$stdout, indent=-1, transitive=false, ie_hack=false)
+++    def write(output=$stdout, indent=-1, transitive=false, ie_hack=false)

Change History

Changed 4 months ago by ernesto.jimenez

  • os changed from Linux to All
  • severity changed from normal to major

+1

This typo broke backwards compatibility

Changed 4 months ago by rubys

  • owner changed from ser to rubys

Changed 4 months ago by rubys

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 3.1.8

Fixed, but it is worth noting that the method is now deprecated.

Changed 4 months ago by rubys

Changed 4 months ago by ernesto.jimenez

Thank you Sam

I'll try to give you something better next time ;)

Great Job with REXML!

Note: See TracTickets for help on using tickets.